kubeovn / kube-ovn / 26878253837

26%

master: 26%

Build Type

Pull #6816

github

Committed by oilbeater

Commit Message

perf(ipam): allocation-free IP comparison in range engine

LessThan/GreaterThan allocated two heap big.Int per call via
big.NewInt().SetBytes().Cmp(). These are the innermost primitive of the
range engine (IPRangeList.Find binary search, Separate/Merge/Intersect),
so every pod allocate/release walked them repeatedly.

Replace with an allocation-free per-family compare: IPv4 addresses are
compared as their 4-byte value (To4 does not allocate for 4-byte
storage), otherwise the 16-byte form is compared. Benchmark shows
0 allocs/op and ~7 ns/op versus the previous big.Int path.

This also makes the result consistent with Equal: the old raw-SetBytes
compare mis-ordered mixed 4-byte/16-byte IPv4 representations and treated
0.0.0.0 as equal to ::. Add unit tests covering both edge cases.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

Pull Request Pull Request #6816: perf(ipam): allocation-free IP comparison in range engine

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

14794 of 57721 relevant lines covered (25.63%)

0.3 hits per line