kubeovn / kube-ovn / 26858940715

24%

master: 27%

Build Type

push

github

Committed by oilbeater

Commit Message

fix(controller): correct egress sync status field on ACL update failure (#6804)

When the egress ACL update fails, IngressLastSyncSuccess was being set to
false instead of EgressLastSyncSuccess. This was a copy-paste bug from the
ingress block above. The incorrect status caused:

1. Ingress status to become falsely negative — monitoring/alerting thinks
ingress rules are broken when they are fine.
2. Egress status to become falsely positive — monitoring/alerting thinks
egress rules are synced when they actually failed.

Fix by setting EgressLastSyncSuccess = false in the egress error path.

Signed-off-by: Harisudarsan <sudarshanhari561@gmail.com>
(cherry picked from commit 35cd2a69e)

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

13270 of 54868 relevant lines covered (24.19%)

0.28 hits per line