rm-hull / dot-block / 26843098957

47%

push

github

refactor: relocate error metric increment (#137)

* feat: buffer metrics collection in RequestContext

Refactored telemetry recording to collect data within `RequestContext`
instead of immediate metric emission. This ensures consistency and
avoids partial updates during request processing.

* refactor: centralize telemetry recording in metrics package

Move the telemetry recording logic from `DNSDispatcher` to
`metrics.DnsMetrics` to encapsulate metric operations and reduce
dependency on the dispatcher.

- Introduced `TelemetryData` struct to hold request-scoped telemetry.
- Migrated all `prometheus` recording operations into
`DnsMetrics.RecordTelemetry`.
- Moved geolocation lookup to the background worker to ensure cleaner
data collection flow.

* refactor: move geo-ip lookup logic into metrics

Centralize geolocation logic within the `metrics` package by injecting
the `GeoIpLookup` interface directly into `DnsMetrics`. This removes the
 dependency from the `DNSDispatcher` and simplifies the telemetry
recording flow.

* refactor: encapsulate TelemetryData fields

- Encapsulated `TelemetryData` fields to private to ensure controlled
  access.
- Added setter and helper methods to manage state, improving
  encapsulation and preventing direct field mutation from external
  packages.

* refactor: remove unused metrics structs

Clean up `dispatcher.go` by removing `queryCountInfo` and
`upstreamTTLInfo` structs which are no longer utilized in the
forwarder logic.

* refactor: improve telemetry recording and structure

- Move telemetry state management into `metrics.TelemetryData`.
- Encapsulate metric recording within the `TelemetryData` struct.
- Simplify `GeoIpLookup` usage by removing the wrapper.
- Improve `RequestContext` by delegating telemetry life-cycle
management.

* refactor: optimize telemetry tracking for request types

- Change `requestTypes` slice to a boolean `forwarded` field.
- Encapsulate request type logic within `TelemetryData.Record`.
-... (continued)

1 of 1 new or added line in 1 file covered. (100.0%)

778 of 1644 relevant lines covered (47.32%)

1095.6 hits per line