nvidia-holoscan / holoscan-cli / 26833111926

76%

main: 77%

Build Type

Pull #178

github

Committed by wyli

Commit Message

Address PR #177 review comments: harden image-template formatting + docs

container/core.py:
- _format_image_template: validate HOLOSCAN_CLI_*_IMAGE_FORMAT placeholders
  with string.Formatter and fail via fatal() on unknown/missing fields or an
  invalid template, instead of a raw KeyError/ValueError traceback. Parsing
  the fields (vs. a substring check) also stops escaped braces like
  {{sdk_version}} from being mistaken for a real sdk_version placeholder.
  (coderabbitai, Copilot)
- default_base_image: compute cuda_tag lazily so the host GPU/driver probe
  (and its warning) no longer runs on the branches that return an explicit
  image or fatal without using it. (Copilot)

README.md:
- Rewrite the base-image configuration section as three explicit methods
  (--base-img flag, fully-qualified HOLOSCAN_CLI_BASE_IMAGE, or repository +
  HOLOSCAN_CLI_BASE_SDK_VERSION). (agirault)

tests:
- Cover the new _format_image_template validation paths and the no-host-probe
  fatal path in default_base_image.
- Document the stubbed host probes in test_get_cuda_tag_handles_sdk_and_cuda_matrix
  (clarifies why a None cuda_version resolves to an igpu tag). (tbirdso)

Follow-up to #177.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #178: Address #177 review comments: harden image-template formatting + base-image docs

Coverage Stats

9 of 12 new or added lines in 1 file covered. (75.0%)

1 existing line in 1 file now uncovered.

2865 of 3785 relevant lines covered (75.69%)

0.76 hits per line