safe-global / safe-client-gateway / 26822623758

90%

main: 90%

Build Type

Pull #3018

github

Committed by PooyaRaki

Commit Message

fix(queue): address code review findings on queue migration

- Preserve tx-service origin when queue entry has no origin metadata,
  instead of clobbering it with null (bindQueueOrigins, bindQueueOrigin,
  resolveMultisigTransaction executed branch)
- Translate queue ordering explicitly via typed nonceOrder ('asc'|'desc')
  instead of a fragile substring check; document the -modified degradation
  and key the cache field on nonceOrder
- Use Promise.allSettled in getMultisigTransactionsBatch so one failing
  chunk no longer discards the whole batch (partial enrichment preserved)
- Return the response body from proposeTransaction for consistency with
  the other queue writes
- Adjust message page count when wrong-chain messages are filtered out
- Harden parseOrigin against valid-but-non-object JSON

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #3018: feat: migrate queue operations from TX service to queue service

Coverage Stats

4469 of 5366 branches covered (83.28%)

Branch coverage included in aggregate %.

516 of 562 new or added lines in 45 files covered. (91.81%)

5 existing lines in 2 files now uncovered.

16931 of 18463 relevant lines covered (91.7%)

586.46 hits per line