KarlNaumann / MacroStat / 26812771375

91%

push

github

feat(ECO3IOPC): temperature propensity and docs (#79)

* fix(government-bill-issuance): correct sign of interest payment on bill stock

The Equations docstring on `government_bill_issuance` in both ECO3IOPC and
IOPC subtracted the interest expense on outstanding bills, while the
implementation correctly adds it. Flip the sign in both docstrings so the
documented identity matches the code: expenditure side of the new bill
stock is `G(t) + r(t-1) B_s(t-1)`, revenue side is
`T(t) + r(t-1) B_{CB}(t-1)`.

`docs/models/{ECO3IOPC,IOPC}/equations.rst` is auto-generated from the
docstring via `docs/docs_preprocessing.py`; regenerate both to match.

Surfaced by an external reader of ECO3IOPC.

* feat(ECO3IOPC): wire alpha12 into propensity

The PropensityToConsumeIncomeTemperature parameter was declared but
not read inside the consumption block, so any non-zero value was
silently inert. Subtract `alpha_12 * (Temperature(t-1) -
Temperature(0))` inside `propensity_to_consume_income` and clamp at
zero so warming can lower consumption without driving the propensity
negative.

Temperature(0) is captured at `initialize()` and carried forward each
step via `prior` because `Behavior.forward` resets `state` on entry.
The lag on Temperature is forced by step ordering: `temperature()`
runs after this method.

Default `alpha_12 = 0`, so the baseline trajectory matches master
exactly. Tests pin terminal propensity and consumption at the default
and exercise the directional, monotonicity, and clamp properties at
non-zero values.

Also folded in three mechanical docstring repairs that the linter
flagged on the same files: `expected_disposable_income` math block
now wraps `\begin{align}`; `temperature` Sets section names
`Temperature` (was `CumulativeCO2`); `VariablesECO3IOPC.check_health`
collapses two math blocks into one.

* fix(ECO3IOPC): show shock in Perturbation 1 plots

The bottom Money Share and Bills Share panels in Perturbation 1 read
the baseline `output` dataframe... (continued)

511 of 552 branches covered (92.57%)

Branch coverage included in aggregate %.

3439 of 3798 relevant lines covered (90.55%)

5.43 hits per line