medplum / medplum / 26785575663

92%

main: 92%

push

github

Remove browser history pollution from some internal redirects (#9367)

When using some links in the sidebars of app.medplum.com or
provider.medplum.com, these components would see that you landed on a
page without default search parameters and push a new history entry for
the same URL with the search parameters. This had some unfortunate
consequences:

- The browser's "back" button stops working as intended: clicking "back"
  after one of these redirects happened would take you back to the
  unqualified page, which would immediately redirect you forward to the
  version with the default search parameters again. It takes either a
  slow browser or superhuman reflexes to click back fast enough to
  actually go back in your history.

- The browser's history list shows those intermediate pages in the
  history list, which makes it appear quite lengthy and confusing.

By using the "replace" option here when normalizing a URL to match the
actual search parameters in use, the existing history entry is updated
instead of having a new one created.

Signed-off-by: Noah Silas <noah@medplum.com>

22514 of 25279 branches covered (89.06%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

35859 of 38086 relevant lines covered (94.15%)

23330.78 hits per line