rm-hull / dot-block / 26784595023

47%

push

github

feat: filter noise in DNS error logging (#134)

* feat: filter noise in DNS error logging

- Introduce `RcodeError` to categorize DNS errors.
- Update `reportError` to check `ShouldLog` before logging and sending
to Sentry.
- Suppress logs and Sentry alerts for `NXDOMAIN` errors.
- Add tests to verify error logging behavior for `NXDOMAIN` vs
`SERVFAIL`.

* Update internal/forwarder/errors.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* fix: handle nil error in RcodeError.Error()

Prevent potential nil pointer dereference by providing a fallback
string representation using the Rcode value when the wrapped error
is nil.

* refactor: improve test setup and suppress NOTIMP logs

- Refactored `setupDispatcherTest` to accept a custom `slog.Logger`,
reducing code duplication in test files.
- Updated `RcodeError.ShouldLog` to exclude `RcodeNotImplemented` from
error logs.
- Added a new test case for `NOTIMP` RCode handling to verify logging
behavior.

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

20 of 27 new or added lines in 2 files covered. (74.07%)

719 of 1584 relevant lines covered (45.39%)

1146.04 hits per line