rm-hull / dot-block / 26778567768

47%

push

github

fix: short circuit DNS-SD queries (#132)

* feat: short circuit DNS-SD queries (RFC 6763)

Prevent DNS-SD queries (matching *._dns-sd._udp.*, excluding _services.*) from being forwarded upstream by returning NXDOMAIN.

* chore: iterative updates from Gemini based on PR comment

I have implemented and verified a new test case, `TestDNSDispatcher_HandleDNSRequest_MixedBlockedAndUpstream`, in `internal/forwarder/dispatcher_test.go`. This test specifically exercises the dispatcher's handling of mixed requests—simultaneously querying a blocked domain and a valid upstream domain—ensuring correct behavior for both.

All existing and new tests in the `internal/forwarder` package have passed, confirming the implementation is robust and functional.

* chore: iterative updates from Gemini based on PR comment

I have successfully implemented the requested test case `TestDNSDispatcher_HandleDNSRequest_DNSSD_NXDOMAIN` in `internal/forwarder/dispatcher_test.go`.

The test verifies that the DNS dispatcher correctly returns `NXDOMAIN` for requests matching `db._dns-sd._udp.0.68.168.192.in-addr.arpa` and confirms that the upstream DNS server is not queried for such requests. All tests in the package passed successfully.

* fix: handle NXDOMAIN for non-SDNS queries

Ensure that DNS requests for non-SDNS queries explicitly return an
`NXDOMAIN` (Name Error) response code instead of potentially returning
an empty successful response.

This improves RFC compliance for DNS resolution logic.

* chore: iterative updates from Gemini based on PR comment

I have implemented the requested handling for RFC 2606 / 6761 reserved TLDs.

### Changes:
1.  **Helper Functions**: Added `isReservedTLD` and `isReservedLocalhost` in `internal/forwarder/dispatcher.go`.
2.  **Dispatcher Logic**: Refactored `processQuestion` to return a `dns.Rcode` along with the response records, and integrated checks for reserved TLDs and `localhost` (loopback).
3.  **HandleDNSRequest**: Updated the request pr... (continued)

53 of 54 new or added lines in 1 file covered. (98.15%)

688 of 1528 relevant lines covered (45.03%)

1176.05 hits per line