payjoin / rust-payjoin / 26771888065

85%

push

github

Fix resume succeding prematurely (#1573)

* Fix resume succeding prematurely

This addresses #1545, upon resuming a session where
the sender posted the original proposal but went ofline,
the cli succeds prematurely and outputs "payjoin transaction
detected in mempool" because the cli treats any Ok(_) as scucess.

This also addresses a subtle issue where after a certain period
without tx detected in the mempool the the monitor_proposal function returned
 Err("Timeout waiting for payment confirmation after 5s").
That looked like a failure even though the session should stay open in Monitor.
And finally the missleading "All resumed sessions completed" message.

Co-authored-by: xstoicunicornx <xstoicunicornx@users.noreply.github.com>

* Add descriptive message to monitor failing to detect TX in mempool

---------

Co-authored-by: xstoicunicornx <xstoicunicornx@users.noreply.github.com>

18 of 25 new or added lines in 1 file covered. (72.0%)

11827 of 13856 relevant lines covered (85.36%)

391.27 hits per line