tomerfiliba / plumbum / 26766755654

88%

push

github

feat(async): support popen on async pipelines (#795) (#804)

* feat(async): support popen on async pipelines (#795)

popen() on an async pipeline previously formulated the pipeline into a
single argv with a literal "|" and exec'd it as one process, so data
never flowed between stages and readline() returned nothing.

Mirror the synchronous Pipeline.popen by connecting the two stages with
an OS pipe, recursing for nested pipelines, and reaping the upstream
process on wait(). As in a shell, the pipeline's return code is that of
its last stage.

Assisted-by: ClaudeCode:claude-opus-4.8
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix: wrap Process to allow setting the returncode

Assisted-by: ClaudeCode:claude-opus-4.8
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>

* fix(async): address pipeline popen review feedback

- Close both pipe fds even if a stage fails to spawn (no read_fd leak)
- Expose the pipeline's stdin from the upstream stage on the proxy,
  matching sync Pipeline.popen (dstproc.stdin = srcproc.stdin)
- Add a communicate() that feeds the head stage and reaps both ends,
  so the upstream process is not left as a zombie

Assisted-by: ClaudeCode:claude-opus-4.8

* fix(async): reap upstream stage if downstream spawn fails

If spawning the downstream pipeline stage raises, the already-started
upstream process was left running and unreaped. Kill and await it on
that error path so no child process or pipe end leaks.

Also reword the return-code comment to describe the pipefail-like
combination accurately.

Assisted-by: ClaudeCode:claude-opus-4.8

* feat(async): support pipeline popen on Windows; propagate signals

- Run the pipeline popen tests on all platforms: move them into a new
  TestAsyncPipelinePopen class (not Windows-skipped) and drive every
  stage with sys.executable instea... (continued)

1260 of 1713 branches covered (73.56%)

75 of 92 new or added lines in 1 file covered. (81.52%)

5354 of 6153 relevant lines covered (87.01%)

11.44 hits per line