safe-global / safe-eth-py / 26763371460

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix: correct oracle price math for non-18-decimal tokens (#2510)

* fix: correct oracle price math for non-18-decimal tokens

- UniswapV2Oracle.get_pool_token_price: use the per-iteration loop
  variable `decimals` instead of the outer `decimals_1`, so the
  token1 fallback path divides by token1's decimals. Previously LP
  prices were off by 10**(decimals_2 - decimals_1) for mixed-decimal
  pools (e.g. WETH 18 / USDC 6).
- KyberOracle.get_price: invert the 1e18-scaled rate with `1e18`
  instead of `token_unit` in the reverse-rate fallback. Previously
  the fallback price was off by 10**(18 - decimals) for non-18-decimal
  tokens (e.g. 10**12 too small for USDC).

* Use a constant for kyber rate precision

Coverage Stats

3 of 4 new or added lines in 2 files covered. (75.0%)

31 existing lines in 3 files now uncovered.

10373 of 11021 relevant lines covered (94.12%)

3.76 hits per line