26761608736

Committed 01 Jun 2026 02:34PM UTC coverage: 0.0% (-95.4%) from 95.403%

Build # 26761608736

Build Type

Pull #2394

github

Committed by

web-flow

Commit Message

Merge e39fc0db2 into e4022a7d8

Pull Request Pull Request #2394: Harden `FileConfigurationPoller` against timer reentrancy and callback thread leaks, and stabilize `TimeoutDelegatingHandler` timeout test

Coverage Stats

0 of 7112 relevant lines covered (0.0%)

0.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

src/Ocelot/Requester/HttpExceptionToErrorMapper.cs

using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.DependencyInjection;
using Ocelot.Errors;
using Ocelot.Request.Mapper;

namespace Ocelot.Requester;

public class HttpExceptionToErrorMapper : IExceptionToErrorMapper
{
    /// <summary>This is a dictionary of custom mappers for exceptions.</summary>
    private readonly IDictionary<Type, Func<Exception, Error>> _mappers;

    public HttpExceptionToErrorMapper(IServiceProvider serviceProvider)
    {
        _mappers = serviceProvider.GetService<IDictionary<Type, Func<Exception, Error>>>();
    }

    public Error Map(Exception exception)
    {
        var type = exception.GetType();

        // If there is a custom mapper for this exception type, use it
        // The idea is the following: When implementing features or providers,
        // you can provide a custom mapper
        if (_mappers != null && _mappers.TryGetValue(type, out var mapper))
        {
            return mapper(exception);
        }

        // here are mapped the exceptions thrown from Ocelot core application
        if (type == typeof(TimeoutException))
        {
            return new RequestTimedOutError(exception); // -> 503 Service Unavailable; TODO but it should actually be 504 Gateway Timeout
        }

        if (type == typeof(OperationCanceledException) || type.IsSubclassOf(typeof(OperationCanceledException)))
        {
            return new RequestCanceledError(exception.Message);
        }

        // Bug #2376 -> https://github.com/ThreeMammals/Ocelot/issues/2376
        // Late Catch: Map the HttpRequestException to a 400 Bad Request.
        // If the header format is invalid, HttpClient throws this exception locally.
        // By catching it here, we ensure Ocelot returns a clean 4xx client error instead of a generic 502 Bad Gateway.
        if (exception is HttpRequestException && exception.Message.Contains("Request headers must contain only ASCII characters."))
        {
            return new BadRequestError(exception); // -> 400 Bad Request
        }

        // Map to a 413 Content Too Large (prior Request Entity Too Large) or 502 Bad Gateway
        if (type == typeof(HttpRequestException) || type == typeof(TimeoutException))
        {
            // Inner exception is a BadHttpRequestException, and only this exception exposes the StatusCode property.
            // We check if the inner exception is a BadHttpRequestException and if the StatusCode is 413, we return a PayloadTooLargeError
            if (exception.InnerException is BadHttpRequestException { StatusCode: StatusCodes.Status413RequestEntityTooLarge })
            {
                return new PayloadTooLargeError(exception); // -> 413 Content Too Large
            }

            return new ConnectionToDownstreamServiceError(exception); // -> 502 Bad Gateway
        }

        return new UnableToCompleteRequestError(exception); // -> 500 Internal Server Error
    }
}

1	using Microsoft.AspNetCore.Http;
2	using Microsoft.Extensions.DependencyInjection;
3	using Ocelot.Errors;
4	using Ocelot.Request.Mapper;
5
6	namespace Ocelot.Requester;
7
8	public class HttpExceptionToErrorMapper : IExceptionToErrorMapper
9	{
10	/// <summary>This is a dictionary of custom mappers for exceptions.</summary>
11	private readonly IDictionary<Type, Func<Exception, Error>> _mappers;
12
13	public HttpExceptionToErrorMapper(IServiceProvider serviceProvider)	×
14	{	×
15	_mappers = serviceProvider.GetService<IDictionary<Type, Func<Exception, Error>>>();	×
16	}	×
17
18	public Error Map(Exception exception)
19	{	×
20	var type = exception.GetType();	×
21
22	// If there is a custom mapper for this exception type, use it
23	// The idea is the following: When implementing features or providers,
24	// you can provide a custom mapper
25	if (_mappers != null && _mappers.TryGetValue(type, out var mapper))	×
26	{	×
27	return mapper(exception);	×
28	}
29
30	// here are mapped the exceptions thrown from Ocelot core application
31	if (type == typeof(TimeoutException))	×
32	{	×
33	return new RequestTimedOutError(exception); // -> 503 Service Unavailable; TODO but it should actually be 504 Gateway Timeout	×
34	}
35
36	if (type == typeof(OperationCanceledException) \|\| type.IsSubclassOf(typeof(OperationCanceledException)))	×
37	{	×
38	return new RequestCanceledError(exception.Message);	×
39	}
40
41	// Bug #2376 -> https://github.com/ThreeMammals/Ocelot/issues/2376
42	// Late Catch: Map the HttpRequestException to a 400 Bad Request.
43	// If the header format is invalid, HttpClient throws this exception locally.
44	// By catching it here, we ensure Ocelot returns a clean 4xx client error instead of a generic 502 Bad Gateway.
45	if (exception is HttpRequestException && exception.Message.Contains("Request headers must contain only ASCII characters."))	×
46	{	×
47	return new BadRequestError(exception); // -> 400 Bad Request	×
48	}
49
50	// Map to a 413 Content Too Large (prior Request Entity Too Large) or 502 Bad Gateway
51	if (type == typeof(HttpRequestException) \|\| type == typeof(TimeoutException))	×
52	{	×
53	// Inner exception is a BadHttpRequestException, and only this exception exposes the StatusCode property.
54	// We check if the inner exception is a BadHttpRequestException and if the StatusCode is 413, we return a PayloadTooLargeError
55	if (exception.InnerException is BadHttpRequestException { StatusCode: StatusCodes.Status413RequestEntityTooLarge })	×
56	{	×
57	return new PayloadTooLargeError(exception); // -> 413 Content Too Large	×
58	}
59
60	return new ConnectionToDownstreamServiceError(exception); // -> 502 Bad Gateway	×
61	}
62
63	return new UnableToCompleteRequestError(exception); // -> 500 Internal Server Error	×
64	}	×
65	}

ThreeMammals / Ocelot / 26761608736

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous