FlexMeasures / flexmeasures / 26761629376

81%

Build Type

push

github

Committed by web-flow

Commit Message

Fix/storage efficiency validation using consumption/production field (#2213)

* fix: @validates("storage_efficiency") uses self.consumption/self.production which are field descriptors, not data values — causing an AttributeError

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: move storage_efficiency validation from DBStorageFlexModelSchema to StorageFlexModelSchema; for backwards compatibility, we need to keep support for a db flex-model with storage-efficiency as a fixed quantity, without a consumption or production sensor, as the trigger message may still describe a power sensor to be used, from which the resolution can be inferred

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: pass validation if device flex-model contains a power sensor (see previous commit)

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* feat: raise explicit error rather than passing silently when the resolution of the
storage-efficiency cannot be inferred

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: update tests

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* refactor: combine tests for checking StorageFlexModelSchema and DBStorageFlexModelSchema

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: streamline punctuation

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: pass in case of trivial storage-efficiency

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* refactor: move most common case to the front

Signed-off-by: F.N. Claessen <claessen@seita.nl>

---------

Signed-off-by: F.N. Claessen <claessen@seita.nl>

Coverage Stats

12 of 13 new or added lines in 2 files covered. (92.31%)

2 existing lines in 1 file now uncovered.

12983 of 16105 relevant lines covered (80.61%)

0.81 hits per line