rm-hull / dot-block / 26746646219
47%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 20
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 43.282% (-0.2%) from 43.484%
26746646219

push

github

web-flow 
chore: update Go dependencies (#128)

* chore: go get -u && go mod tidy

* chore: iterative updates from Gemini based on PR comment

I have investigated the intermittent failure in `internal/forwarder/TestDNSDispatcher_HandleDNSRequest_CacheHit` and identified it as a race condition where the cache update worker (running asynchronously) had not yet processed the `Set` operation before the test checked the metrics.

To resolve this, I implemented a `Sync()` method in `internal/forwarder/cache.go` that allows for explicit synchronization with the background update worker. I then updated the failing test case to use this `Sync()` method before performing its assertions.

The test suite now consistently passes:
```bash
go test -v ./internal/forwarder/...
...
PASS
ok  	github.com/rm-hull/dot-block/internal/forwarder	0.057s
```

* chore: iterative updates from Gemini based on PR comment

I have reverted the `Sync()` method implementation in `internal/forwarder/cache.go` and refactored `internal/forwarder/dispatcher_test.go` to be robust without modifying the source code. The tests in `internal/forwarder` now pass reliably using `assert.Eventually` to wait for asynchronous operations.

* Remove syncCh from cacheUpdate struct

Removed syncCh channel from cacheUpdate struct.

---------

Co-authored-by: rm-hull <1915543+rm-hull@users.noreply.github.com>
Co-authored-by: gemini-pr-agent[bot] <gemini-pr-agent[bot]@users.noreply.github.com>
Co-authored-by: Richard Hull <rm_hull@yahoo.co.uk>

641 of 1481 relevant lines covered (43.28%)

1249.14 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
68.66
 -4.48% internal/forwarder/cache.go
Jobs
ID Job ID Ran Files Coverage
1 26746646219.1 20
43.28
 GitHub Action Run
Source Files on build 26746646219