aelassas / servy / 26741716024

85%

main: 85%

Build Type

push

github

Committed by aelassas

Commit Message

fix(core): EventLogReader.MapToDto - only FormatDescription is guarded; Id/Level/ProviderName/TimeCreated can throw EventLogException and abort the entire enumeration
fix(service): Service.cs OnCustomCommand - fallback path calls Environment.Exit without flushing the logger, losing the diagnostic messages it just wrote
fix(core): ProcessKiller.KillProcessesUsingFile - invokes KillProcessTreeAndParents with default killParents=true, terminating unrelated parent processes that are not holding the file lock
fix(desktop,manager): HelpService.CheckUpdates - HttpResponseMessage from GetAsync is never disposed, leaking the response object and pinning pooled connections longer than necessary
fix(core): ProcessKiller.KillParentProcesses - recursive call passes stale parentStartTime (possibly MinValue) instead of verified exactStartTime, silently truncating the upward walk one level
fix(core): ServiceHelper.CalculateStartTimeout - does not account for PreLaunchRetryAttempts, causing 'Timed out waiting to start' for services with configured pre-launch retries
fix(cli): ExportServiceCommand.SaveFile - SecurityException catch does not delete the stub file created by FileStream.OpenOrCreate, leaving 0-byte artifacts on disk
fix(core): ServiceManager.InstallServiceAsync - cancellation between CreateService and the try/catch rollback block leaves an orphan SCM entry with no DB record
fix(notifications): ServyFailureEmail.vbs / ServyFailureNotification.vbs - shell.Run exit code discarded, so Task Scheduler always records 0x0 even when the PowerShell child fails
fix(service): Service.cs hook launchers - ExpandAndAudit args/env then ProcessLauncher.Start expands them a second time (double expansion, env audit work wasted)
fix(core): EventLogReader.ReadEvents - for-loop fetches one extra EventRecord past maxReadCount; a throw on that read aborts the whole batch the caller had already received
fix(cli): ExportServiceCommand.SaveFile - generic catch reports ordinary write ... (continued)

Coverage Stats

1612 of 2189 branches covered (73.64%)

Branch coverage included in aggregate %.

191 of 224 new or added lines in 9 files covered. (85.27%)

2 existing lines in 1 file now uncovered.

11239 of 16393 relevant lines covered (68.56%)

796.73 hits per line