kubernetes-sigs / lws / 26700104325

56%

push

github

[DisaggregatedSet][2/N] Add controller implementation with rolling update support (#836)

* [DisaggregatedSet][2/N] Add controller implementation

Add the full DisaggregatedSet controller implementation, migrated from
the standalone disaggregatedset module into the main LWS repository.

Components added:
- Reconciler with stateless rolling update detection
- Rolling update executor with coordinated drain and newest-first
  drain ordering for multi-revision scenarios (A→B→C)
- Stateless linear interpolation planner for N-role rolling updates
- LeaderWorkerSet manager for workload CRUD operations
- Service manager for headless portless endpoint discovery
- Utility functions for revision computation, labels, and naming

Key behaviors:
- Coordinated drain prevents orphan workloads across roles
- Newest-first drain ordering ensures broken intermediate revisions
  drain before stable originals
- maxSurge=0 correctly uses maxUnavailable for batch sizing
- Stability gate blocks progress until new workload is fully ready

Signed-off-by: Mathis Felardos <mathis@mistral.ai>

* [DisaggregatedSet][2/N] Add unit and integration tests

Add comprehensive test coverage for the DisaggregatedSet controller,
migrated from the standalone module with import path and API version
updates (v1alpha1 -> v1, LeaderWorkerSetTemplateSpec wrapping).

Test files:
- executor_test.go: drain ordering, coordinated drain, A→B→C scenarios,
  scaleUp/scaleDown operations, role change detection
- planner_test.go: rolling update step computation, linear interpolation,
  surge/unavailable constraints, orphan prevention, N-role support
- workload_manager_test.go: LWS CRUD, initial-replicas annotation,
  revision computation, metadata merging
- service_manager_test.go: headless service lifecycle, cross-role
  readiness coordination, drained service cleanup
- utils_test.go: label/naming utilities, owner reference management
- disaggregatedset_controller_test.go: integration tests with envtest

S... (continued)

966 of 1173 new or added lines in 6 files covered. (82.35%)

2150 of 3830 relevant lines covered (56.14%)

45.88 hits per line