KarpelesLab / libwallet / 26677240100

23%

push

github

fix Ed25519 self-heal segfault on FROST wallets + bump to 0.4.47

EnsureEd25519Pubkey and the legacy ed25519 sign-path self-heal gated
only on Wallet.Curve == "ed25519", not on Protocol. FROST wallets share
that curve, so the helper decoded the FROST share into an
*eddsatss.Key. fxamacker/cbor silently zero-filled the unknown fields,
leaving EDDSAPub nil; the chained ToEd25519PubKey() then dereferenced a
nil *ECPoint at offset 0x10 (EXC_BAD_ACCESS) when the user switched
wallets in the host app.

Both self-heal sites now gate on resolveProtocol() == ProtocolLegacyEdDSA.
decryptEdDSA also returns an explicit error when the decoded share
lacks EDDSAPub, so any future miswired caller fails loudly instead of
segfaulting.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 8 new or added lines in 2 files covered. (0.0%)

4028 of 18371 relevant lines covered (21.93%)

102.8 hits per line