dcdpr / jp / 26667012764

66%

push

github

fix(attachment_cmd_output, cli): Improve errors on attachment failures (#701)

When an attachment handler failed, the error was converted to a plain
string (`Error::Attachment(e.to_string())`), discarding the source
error's cause chain and losing track of which URI triggered the failure.

A new `Error::AttachmentFailed { uri, source }` variant now carries both
the offending URI and the boxed source error. All call sites in
`register_attachment` and `validate_attachment` have been updated to use
it, so the user sees which attachment failed and the full underlying
reason.

On the `cmd://` side, a failed spawn produced a bare `io::Error` ("No
such file or directory") with no mention of the binary name. The command
line is now captured before calling `.run()` and prepended to the error
message, e.g.: `failed to run command \`jp-definitely-missing-binary
--check\`: ...`

The `AttachmentFailed` variant is also wired into the CLI error renderer
so the URI appears in the structured output alongside the cause chain.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

4 of 15 new or added lines in 3 files covered. (26.67%)

32758 of 49634 relevant lines covered (66.0%)

258.46 hits per line