Qiskit / qiskit / 26661816187

88%

Build Type

push

github

Committed by web-flow

Commit Message

Use a single type alias for indexmap and indexset to enforce hasher (#16130)

Building off of #15920 which moved our hasher for IndexMap usage to be
foldhash this moves to having a common type alias for IndexMap and
IndexSet that has the hasher set. All the internal usage of IndexMap and
IndexSet are updated to use this new alias instead which removes the
boiler plate around dealing with initializing the hasher for the most
part, the only exception is when using `with_capacity_and_hasher()`
there is no method to create an empty object with a capacity
preallocated and the hasher is initialized from the generic type. To
enforce that we're using the correct hasher for all indexmap usage the
clippy rules are updated to disallow the indexmap::IndexMap and
indexmap::IndexSet types directly. This means that after this commit all
indexmap usage with be forced by clippy to leverage our standard pattern
using foldhash. The advantage is if we ever need to change the default
hasher again in the future we only need to update one central place
(and the places using with_capacity_and_hasher).

Coverage Stats

152 of 161 new or added lines in 29 files covered. (94.41%)

26 existing lines in 4 files now uncovered.

108500 of 123920 relevant lines covered (87.56%)

966497.22 hits per line