dcdpr / jp / 26659880341

66%

push

github

fix(config): Honor `create_if_missing` for missing dirs (#698)

`ConfigLoader::load` rejected any path that was not an existing
directory with "provided path is not a directory", returning that error
before its `create_if_missing` branch could run. Because that branch is
the only code that calls `create_dir_all`, the loader could create a
config file inside an existing directory but never create the directory
itself, contradicting the intent of `create_if_missing`.

This surfaced on a fresh machine running `jp init`: when persisting the
`user.name` attribution to the user-global config, the loader is pointed
at the platform config directory (e.g. `~/.config/jp` on Linux). On a
machine that has never run `jp`, that directory does not exist yet, so
init aborted with `provided path is not a directory` right after the
model-selection prompt.

The guard now rejects only a path that exists but is not a directory, or
a missing path when `create_if_missing` is unset. A missing directory
with `create_if_missing` set falls through to the create branch, which
creates both the directory and the file. Non-creating callers (such as
`jp config show --global`) keep returning the same error on a missing
directory.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

32024 of 48249 relevant lines covered (66.37%)

233.83 hits per line