HarryR / nt365 / 26656788012

44%

Build Type

push

github

Committed by HarryR

Commit Message

afd: strip dead connect/disconnect-data machinery

AFD carried a full connect-data / connect-options / disconnect-data /
disconnect-options vertical (AFD_CONNECT_DATA_BUFFERS, 8 slots, 12 IOCTLs,
plus the ws2_32 SO_CONNDATA/CONNOPT/DISCDATA/DISCOPT sockopt mappings). It
only does anything for legacy connection-oriented transports whose handshake
PDUs carry user payload (OSI TP4, DECnet, AppleTalk, SPX-II). MicroNT is
IPv4 + TCP/UDP + raw IP only, and the TCP/IP TDI transport neither emits nor
accepts connect data, so the entire vertical is dead code no transport can
ever exercise.

Removed:
  - AFDSTR.H: AFD_CONNECT_DATA_INFO/AFD_CONNECT_DATA_BUFFERS structs and the
    ConnectDataBuffers field from AFD_CONNECTION and AFD_ENDPOINT.
  - MISC.C: AfdGetConnectData/AfdSetConnectData/AfdFreeConnectDataBuffers.
  - DISPATCH.C: the 12 IOCTL_AFD_{SET,GET}_{CONNECT,DISCONNECT}_{DATA,OPTIONS}
    + IOCTL_AFD_SIZE_* cases.
  - CONNECT.C: AfdSetupConnectDataBuffers + the connect-data blocks in
    AfdConnect/AfdRestartConnect.
  - LISTEN.C: CopyConnectDataBuffers/CopySingleConnectDataBuffer + the
    AfdConnectEventHandler connect-data capture.
  - DISCONN.C: the inbound disconnect-data capture and the AfdBeginDisconnect
    connect-data block.
  - BLKCONN.C/BLKENDP.C: the AfdFreeConnectDataBuffers teardown calls.
  - INC/AFD.H: the 12 IOCTL definitions.
  - WS2_32/SOCKOPT.C: the SO_CONN*/SO_DISC* get/setsockopt cases and the
    SockPassConnectData helper (those sockopts now return WSAENOPROTOOPT).

Live paths preserved: TdiBuildConnect keeps RemoteAddress, TdiBuildDisconnect
gets NULL connection-info (correct for TCP/IP), accept/connection setup and
poll indications are untouched. The separate endpoint Context mechanism
(IOCTL_AFD_*_CONTEXT, endpoint->Context — ws2_32 per-socket state) is left
intact. 1087 lines deleted; afd.sys and ws2_32.dll build clean and the AFD
selftest (UDP/TCP loopback, accept, DNS, HTTP) passes.

Co-Authored-By: Claude Opus 4.8 (1M con... (continued)

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

155 existing lines in 10 files now uncovered.

47741 of 113979 relevant lines covered (41.89%)

2776.14 hits per line