Alan-Jowett / sonde / 26652723963

82%

push

github

fix: replace `desiredstate` upsert with append-only insert (#1100)

* fix: replace `desiredstate` upsert with append-only insert (#1097)

Remove `insert_or_replace` from the gateway `desiredstate` table path and
replace with a plain `insert` using a fresh `next_history_row_key()` RowKey.
This preserves original SPA-written rows for audit purposes.

Changes:
- Rename `upsert_gateway_desired_state` to `append_gateway_desired_state`
  across the `HandlerStore` trait and all implementations
- Azure Table impl: use `table.insert()` instead of
  `entity_client.insert_or_replace()`
- Call site: generate a new RowKey with the current message timestamp instead
  of reusing the existing row's RowKey
- MemoryStore: change from single-row HashMap to append-only Vec, with load
  returning the lexicographically smallest RowKey (matching Azure top-1)
- T-AZH-0603 test: add assertion that both original and cleared rows exist
  with distinct RowKeys after epoch increment
- Update AZH-0603, AZH-0605 requirements and design docs with append-only
  semantics

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix: clarify doc comment on append_gateway_desired_state

Caller must provide a unique RowKey; store inserts without replacing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

19 of 21 new or added lines in 1 file covered. (90.48%)

38261 of 46611 relevant lines covered (82.09%)

248.82 hits per line