endoze / jjwt / 26650220256

98%

master: 98%

push

github

refactor: improve code quality, ergonomics, and hot-loop performance

Replace string-based shell selection with a typed enum to catch invalid
shell kinds at compile time. Simplify RemoveArgs by moving workspace
name from struct field to function parameter, eliminating redundant
per-workspace copies.

Optimize jj_lib workspace resolution by introducing trunk-aware variants
of internal_ws_name and wc_commit_id that accept pre-resolved trunk
bookmarks, avoiding repeated resolution in hot loops during diff and
blame computations.

Replace multiple Vector::as_slice() calls with slice references using
the & operator for better ergonomics. Simplify truncate_line logic to
correctly handle edge cases and avoid premature truncation detection.

Use Value::from() for cleaner serde_json construction instead of
explicit Value::String wraps. Replace Iterator::last() with
next_back() in test assertions for correctness on DoubleEndedIterator.

Remove unnecessary clone operations in various contexts where references
or move semantics suffice. Improve error handling in jj config setup
by propagating context through write! operations. Update function
signatures to accept Path instead of PathBuf where appropriate.

48 of 57 new or added lines in 3 files covered. (84.21%)

1294 of 1319 relevant lines covered (98.1%)

182.26 hits per line