3bec20ba14a405382687d9044fc30b5c28d6ae30-PR-1475
76%
main: 72%

Ran 29 May 2026 11:47AM UTC

Jobs 1

Files 539

Run time 1min

Badge

Embed ▾

Committed 29 May 2026 11:37AM UTC coverage: 75.726% (-0.05%) from 75.78%

Build # 3bec20ba14a405382687d9044fc30b5c28d6ae30-PR-1475

Build Type

Pull #1475

github

Committed by

OmarBrbutovic

Commit Message

fix: propagate handler results and optimize dispatch pipeline

Fixes an issue where trigger errors were being swallowed by the
orchestration pipeline. Previously, `map_handling/5` and
`handle_trigger/3` intercepted execution errors but implicitly
returned `:ok` via Logger side effects and hardcoded terminal tokens.
This prevented failures from bubbling up to the controller layer
and Astarte.

Changes include:
- Refactor `map_handling/5` to use a `case` statement that explicitly
  logs and passes through `{:error, reason}` tuples.
- Update `handle_trigger/3` to return the evaluation result of the
  handler pipeline instead of hardcoding `:ok`.
- Refactor `AstarteTriggerController` to uniformly forward error tuples
  to `FallbackController` while standardizing success shapes.
- Implement a fallback for empty handler lists (`{:ok, :no_handlers}`)
  to avoid runtime match crashes.
- Replace an `Enum.filter |> Enum.map` pipeline with an idiomatic `for`
  comprehension in `handlers_from_payload/1`.
- Clean up `if/else` structures into declarative function head patterns.

Signed-off-by: Omar <omar.brbutovic@secomind.com>

Pull Request Pull Request #1475: fix: propagate handler results and optimize dispatch pipeline

Coverage Stats

3444 of 4548 relevant lines covered (75.73%)

759.7 hits per line

Coverage Regressions

Lines	Coverage	∆	File
6	75.76	-6.74%	lib/extensions/triggers/handler.ex
1	89.06	-1.56%	lib/edgehog/campaigns/campaign_mechanism/deployment_upgrade/core.ex

Jobs

ID	Job ID	Ran	Files	Coverage
1	3bec20ba14a405382687d9044fc30b5c28d6ae30-PR-1475.1	29 May 2026 11:47AM UTC	539	75.73	GitHub Action Run

edgehog-device-manager / edgehog / 3bec20ba14a405382687d9044fc30b5c28d6ae30-PR-1475
76%
main: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 3bec20ba14a405382687d9044fc30b5c28d6ae30-PR-1475

edgehog-device-manager / edgehog / 3bec20ba14a405382687d9044fc30b5c28d6ae30-PR-1475 76% main: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 3bec20ba14a405382687d9044fc30b5c28d6ae30-PR-1475

edgehog-device-manager / edgehog / 3bec20ba14a405382687d9044fc30b5c28d6ae30-PR-1475
76%
main: 72%

README BADGES
x