safe-global / safe-client-gateway / 26629381691

90%

Build Type

push

github

Committed by web-flow

Commit Message

feat: per-Space onboarding survey module (#3107)

* feat: add Space onboarding survey module

Adds a per-Space survey collected as the final step of Space onboarding.
Captures usage intent (operate protocol, run payments, hold assets, etc.)
for analytics and future per-Space personalisation. Only space admins can
read/write; submission overwrites the prior answer for the space.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: make SurveyResponseResultDto a type-only import in surveys service

It is only referenced as a type annotation; the value import added no runtime usage.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor(surveys): structure survey_content + selections as pages

Reshape the survey JSONB and the per-Space response payload so multi-page
surveys can ship later without breaking the analytics property schema
sent to Mixpanel.

- survey_content: { multiSelect, options[] }
                → { pages: [{ id, title, subtitle, multiSelect, options[] }] }
- selections (column + DTO):
    string[] → Record<pageId, string[]>
- Service validates: every page id present, no unknown ids, each page's
  selections ⊆ that page's option keys, single-select pages allow only 1.
- Migration seed now produces a one-page onboarding survey; the column
  type is unchanged (JSONB) so no schema change beyond data shape.
- e2e tests updated to the new wire shape; new tests cover missing-page,
  unknown-page-id, and unknown-key-within-page error paths.

surveys.title / surveys.subtitle remain as admin-facing labels (handy
for Mixpanel event metadata and a future admin UI); user-facing headers
now live on the page itself.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(surveys): atomic upsert via repo.upsert + apply biome formatting

Replace the find-then-update-or-insert pair in SurveysRepository.upsertResponse
with a single repo.upsert (Postgres INSERT ... ON CONFLICT DO U... (continued)

Coverage Stats

4315 of 5180 branches covered (83.3%)

Branch coverage included in aggregate %.

178 of 184 new or added lines in 12 files covered. (96.74%)

2 existing lines in 2 files now uncovered.

16404 of 17893 relevant lines covered (91.68%)

583.92 hits per line