dcdpr / jp / 26628352543

66%

Build Type

push

github

Committed by web-flow

Commit Message

enhance(cli, task): Interactive Ctrl+C drain with force-quit escalation (#687)

When `jp` finishes its main work, it waits for background tasks (e.g.
title generation) before exiting. Previously this was a silent, blocking
call with no user feedback and no way to interrupt it.

This commit replaces that with an interactive drain loop. If background
tasks are still running after 1 second, a `⏱ Finishing background tasks…
Ns` line is printed to stderr (TTY only). The first Ctrl+C
(SIGINT/SIGTERM) switches the line to a 2-second countdown and signals
graceful cancellation via the existing soft-cancel token. A second
Ctrl+C — or SIGQUIT — escalates to a hard force-quit that aborts the
`JoinSet` immediately and drops any pending workspace mutations.

The escalation path required a second `force_token` on `TaskHandler`.
The soft-cancel token already existed but was only fired internally; it
is now also exposed via `cancel_token()` so the drain loop can signal it
externally. `is_empty()` is added to short-circuit the whole drain when
there is nothing to wait for.

As a related fix, `TitleGeneratorTask` now accepts an `is_tty` flag and
suppresses the OSC-2 terminal-title sequence when the process is not
attached to a TTY. Without this guard, the escape bytes leaked into
captured pipes or CI logs when running `jp` non-interactively.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

11 of 86 new or added lines in 4 files covered. (12.79%)

11 existing lines in 3 files now uncovered.

31992 of 48235 relevant lines covered (66.33%)

267.55 hits per line