dcdpr / jp / 26625401120

66%

Build Type

push

github

Committed by web-flow

Commit Message

fix(printer): Strip ANSI sequences split across writes (#684)

`strip_ansi_escapes::strip_str` was called once per task, so a CSI
sequence emitted across multiple `write_str` calls (which is exactly
what `write!`/`writeln!` and crossterm do internally) was never seen as
a complete sequence. The escape introducer got dropped while the
parameter bytes survived, producing cruft like `38;5;11m1mgit_diff` in
non-pretty output modes.

Introduce `AnsiStripper<W>` in a new `ansi` module: a `Write` wrapper
that drives a `vte::Parser` over every byte written to it. Because the
parser state lives on the struct, escape sequences split across any
number of calls are correctly recognized and discarded. Only printable
characters and newlines are forwarded to the inner writer.

The `Worker` in `printer.rs` no longer holds a bare `O`/`E` writer pair.
Instead, each stream is wrapped in a new `Sink<W>` enum that is either
`Raw` (pretty formats, pass bytes through) or `Strip` (all other
formats, route through `AnsiStripper`). This means each stream owns its
own persistent parser state, so an open sequence on `out` can never
consume bytes destined for `err`.

Fixes #683

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

45 of 47 new or added lines in 2 files covered. (95.74%)

1 existing line in 1 file now uncovered.

31988 of 48149 relevant lines covered (66.44%)

253.95 hits per line