clay / claycli / 26611081313

87%

master: 87%

Build Type

Pull #252

github

Committed by jjpaulino

Commit Message

🍕 Inline client process.env vars into Vite bundle at build time

CJS modules that read process.env.X at load time compile to an empty
`var pVt = {}` stub under @rollup/plugin-commonjs, so reads like
process.env.PYXIS_HOST resolve to undefined and never reach the
runtime-hydrated window.process.env. This silently broke every Kiln
plugin / universal service that reads env at module eval (pyxis, agora,
glaze, …) — they worked in the legacy pipeline only because dotenv-webpack
inlined those reads as string literals.

Extend buildDefines() to inline client-facing process.env vars via Vite's
define map, mirroring dotenv-webpack. The var list comes from
client-env.json (the same browser surface amphora-html already forwards to
window.process.env), with a cold-build fallback to all valid env keys so a
fresh CI checkout still inlines. define only substitutes referenced tokens,
so an over-inclusive list never leaks an unreferenced secret into the bundle.

Add focused unit tests for inlining, the cold-build fallback, and the
invalid-identifier filter.

Co-authored-by: Cursor <cursoragent@cursor.com>

Pull Request Pull Request #252: 🍕 Add Kiln plugin init diagnostics for Vite

Coverage Stats

764 of 949 branches covered (80.51%)

Branch coverage included in aggregate %.

43 of 43 new or added lines in 2 files covered. (100.0%)

56 existing lines in 1 file now uncovered.

1632 of 1802 relevant lines covered (90.57%)

13.35 hits per line