wboayue / rust-ibapi / 26609624221

92%

push

github

align: code-consistency sweep — rules 2, 8, 17, 18, 19, 27 (#657)

* align: matching_symbols return type + peek_int proto guard

Rule 27 (sync/async signature parity):
- Client::matching_symbols sync side returned
  Result<impl Iterator<Item = ContractDescription>, Error>;
  async returned Result<Vec<ContractDescription>, Error>.
  The sync impl already collected into Vec internally before
  wrapping with .into_iter(), so the abstraction was pure surface
  drift. Unify both on Vec; update 2 unit tests + 2 integration
  tests that called .collect() on the result.
- Add migration section 32 documenting the change.

Rule 17 (proto-aware text-index accessors):
- ResponseMessage::peek_int(&self, i) read self.fields[i]
  unconditionally. Production callers (request_id text-fallback,
  handshake parser) already gate on raw_bytes().is_none() before
  invoking, so the accessor was safe by construction. The rule
  literally requires the accessor itself to be defensive: add a
  raw_bytes().is_some() short-circuit returning
  Err(UnexpectedResponse(_)); add a unit test exercising the guard.

* align: extract 7 inline test blocks; capture follow-up plan

Rule 8 (separate test files): the project convention is sibling
foo_tests.rs files wired in with
`#[cfg(test)] #[path = "..._tests.rs"] mod tests;`, not inline
`#[cfg(test)] mod tests { ... }` blocks. Audit found 22 files still
using the inline form. Extract the 7 smallest (each under 30 lines)
to set the pattern in this branch:

- market_data/realtime/mod.rs -> mod_tests.rs
- transport/common.rs -> common_tests.rs
- contracts/common/stream_decoders.rs -> stream_decoders_tests.rs
- display_groups/common/encoders.rs -> encoders_tests.rs
- wsh/common/stream_decoders.rs -> stream_decoders_tests.rs
- market_data/historical/common/encoders.rs -> encoders_tests.rs
- scanner/common/stream_decoders.rs -> stream_decoders_tests.rs

Each is a 1-to-1 move: the entire `use super::*;` + test fns block
is lifted into the sibling... (continued)

6 of 6 new or added lines in 2 files covered. (100.0%)

18029 of 19657 relevant lines covered (91.72%)

29.74 hits per line