dcdpr / jp / 26605957513

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix(llm, openai): Fix nullable `array`/`object` params in strict mode (#674)

OpenAI's strict validator was rejecting tool-call schemas that encoded
optional array/object parameters as `{type: ["array", "null"], items:
...}`. The validator treats `items` as orphaned from the array type
variant in a union, causing an "array schema missing items" error.

The fix changes `make_schema_nullable` to use an `anyOf` wrapper for
structured types (`array`, `object`) instead of extending the `type`
field into an array. Primitives (`string`, `integer`, etc.) keep the
simpler `{type: ["string", "null"]}` form, which OpenAI accepts without
issue. This matches the shape emitted by Pydantic/OpenAI's own SDK for
`Optional[List[T]]` and `Optional[BaseModel]`.

As part of this work, the two previously separate strict-mode helpers —
`transform_schema` (used for structured outputs) and
`enforce_strict_object_structure` (used for function-calling) — are
unified into a single in-place `ensure_strict_schema(&mut Value)`
function. Both code paths now share identical semantics: objects get
`additionalProperties: false`, every property lands in `required`, and
previously-optional properties are made nullable. The old
`make_config_nullable` helper (which operated on `ToolParameterConfig`
directly) is removed; nullability is now always injected at the JSON
schema level.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

96 of 105 new or added lines in 1 file covered. (91.43%)

2 existing lines in 1 file now uncovered.

31552 of 47833 relevant lines covered (65.96%)

264.2 hits per line