google / OpenSK / 26605083306

97%

2.1: 97%

push

github

Fix CTAPHID transaction timeout bug and user presence state leaks (#777)

This commit addresses responsiveness issues and CTAP protocol deviations
in the USB HID transport and user presence handling:

1. User Presence State Leak: When a user presence request is interrupted
   (e.g., by a timeout or an incoming USB packet), the touch state was
   incorrectly left running in the background. This prevented subsequent
   LED blinking and caused a panic if hardware interrupts (bounces) were
   queued. The `Touch` struct now correctly implements `Drop` to clear
   the state, and event handling safely ignores stale interrupts.

2. Transaction Timeout Race Condition: Following a transaction timeout
   (CTAP 2.1 Section 11.2.5.2), the firmware incorrectly dropped the
   next incoming packet while returning a `MsgTimeout` error. If the
   host initiated a new transaction with a `CTAPHID_INIT` packet
   immediately after a timeout, the new initialization packet was
   discarded, leaving the host waiting indefinitely. The timeout logic
   now preserves new initialization packets and only returns a timeout
   error if the host sends a continuation packet for the aborted message.

27 of 27 new or added lines in 1 file covered. (100.0%)

13241 of 13612 relevant lines covered (97.27%)

10322.5 hits per line