stacklok / toolhive / 26576164699

66%

Build Type

push

github

Committed by web-flow

Commit Message

Add StorageVersionMigrator controller (opt-in, default off) (#5362)

* Add StorageVersionMigrator controller (opt-in, default off)

Adds a StorageVersionMigrator controller to the operator behind a
default-off feature flag (ENABLE_STORAGE_VERSION_MIGRATOR). The
controller reconciles status.storedVersions on opted-in
toolhive.stacklok.dev CRDs by issuing a Get+Update against each CR,
which re-encodes etcd objects to the current storage version. This
is required before a future release can drop a deprecated apiVersion
(e.g. v1alpha1) from spec.versions without orphaning rows.

The flag defaults to false, so this PR has no functional impact for
any user until they explicitly opt in via operator.env. Helm chart
exposure (values.yaml flag entry and deployment env-var wiring) is
deferred to a follow-up PR to reduce accidental enablement during
the deprecation window.

RBAC for the controller's verbs ships in this PR so the flag can be
flipped on at any time without permission-denied errors. Opt-in
label markers on the 12 v1beta1 root types and the marker-coverage
CI test are deferred to a follow-up PR; the envtest suite creates
its own CRDs at runtime and is independent of those changes.

Part of #4969.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Address PR review feedback

- F1: fix doc comment claiming "Enabled by default" — the controller is
  default-off in this release, opt-in via env var only; chart surface
  lands in a follow-up PR
- F2: fail loudly on unparsable env-var value instead of silently
  defaulting to disabled (per go-style "Fail Loudly")
- F6: document why patchStoredVersions cannot use the operator-wide
  MutateAndPatchStatus helper (CRD storedVersions is co-owned with
  kube-apiserver, optimistic lock is load-bearing)
- F7: demote disabled-state log from INFO to V(1) (silent success)
- F8: prefix env var with TOOLHIVE_ to match sibling operator env vars
  and avoid cross-operator collisions
- Codespell: unpa... (continued)

Coverage Stats

195 of 304 new or added lines in 2 files covered. (64.14%)

587 existing lines in 8 files now uncovered.

65709 of 99582 relevant lines covered (65.98%)

64.43 hits per line