wboayue / rust-ibapi / 26555011555

92%

Build Type

push

github

Committed by web-flow

Commit Message

accounts: add 5 remaining protobuf APIs (#653)

* accounts: add 5 remaining protobuf APIs

Closes the protobuf-migration tracker by exposing the last gaps as Client
methods (sync + async): soft_dollar_tiers, user_info, request_fa, replace_fa,
set_server_log_level, verify_request, verify_message.

* accounts: address code review findings

- decode_receive_fa_proto now rejects None fa_data_type (rule 16);
  FaConfig exposes the validated FaDataType so callers can verify the
  server echoed the requested dataset
- Add VerifyCompleted failure-path round-trip test
- Tests derive wire ints from enums (FaDataType / ServerLogLevel) per rule 21
- Alphabetize UserInfo in text_request_id_field
- FaReplaceRequestBuilder default request_id now matches production
  allocator (TEST_REQ_ID_FIRST)

* accounts: add examples + integration tests for new APIs

12 examples (6 sync + 6 async, with verify_request/verify_message
combined into verify_handshake since they form a single protocol flow)
covering soft_dollar_tiers, user_info, request_fa, replace_fa,
set_server_log_level, verify_handshake.

Integration tests in integration/{sync,async}/tests/accounts.rs:
- soft_dollar_tiers_succeeds, user_info_succeeds, set_server_log_level_succeeds
  run on any account
- request_fa_groups, replace_fa_round_trip, verify_handshake marked
  #[ignore] (require FA account or IB Linking setup)

* examples/accounts: address code review findings

- replace_fa: require explicit fa_data_type arg (no default), prompt
  before reading stdin, refuse to send empty XML (avoids silently
  clobbering FA configuration on a no-arg invocation)
- verify_handshake: add inline comment noting verify_message expects
  the RSA-signed challenge in real use; CLI arg is a stub
- verify_handshake integration test: extend to call verify_message
  (with raw challenge.api_data) so both halves of the protocol are
  exercised when the #[ignore] is lifted

Coverage Stats

445 of 492 new or added lines in 6 files covered. (90.45%)

1 existing line in 1 file now uncovered.

19896 of 21528 relevant lines covered (92.42%)

26.87 hits per line