humanspeak / svelte-motion / 26531902391

69%

main: 3%

push

github

fix(motion): persist animated transforms after WAAPI completion (#383)

* fix(motion): persist animated transforms after WAAPI completion

A motion.* element with a transform-shortcut animate value (scaleX,
rotate, x, y, etc.) animated correctly but reverted to transform:none
once the WAAPI run finished, because the inline transform was cleared at
the 'ready' state and WAAPI's default fill:'none' surrenders the
property on completion.

- Promote the animate target to the inline-style baseline once the enter
  animation has COMPLETED (new enterAnimationSettled flag set in the
  animateWithLifecycle onComplete), so the element holds its target. The
  target must not be applied during the run — flipping the inline value
  mid-animation shows the target for the one frame it changes (a visible
  snap), since WAAPI's composite doesn't override that exact frame.
- Collapse keyframe-array targets to their resting (last) element via a
  new resolveRestingValues helper (animate={{x:[0,100,50]}} rests at 50),
  mirroring upstream's buildTransform reading a settled scalar.
- Filter the inline baseline through filterReducedMotionKeyframes so
  transforms stay stripped under reduced motion.

Verified against framer-motion: inline style is built from resolved
values every render (use-props.ts), buildTransform reads settled scalars
and emits 'none' for identity (so identity targets like scaleX:1 are
correctly 'none' — the bug only bites non-identity targets).

Adds unit coverage (resolveRestingValues + persistence) and an e2e route
+ spec, including an addInitScript frame-recorder guard that asserts no
start-of-animation snap.

Closes #377

* fix(motion): omit empty-array keys in resolveRestingValues

CodeRabbit follow-up on #383: resolveRestingValues({ x: [] }) returned
value[-1] = undefined, yielding { x: undefined }. Harmless downstream
(mergeInlineStyles guards null/undefined) but untidy in isolation — now
empty-array keys are dropped. Adds a unit test.

Refs #377

530 of 718 branches covered (73.82%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 2 files covered. (100.0%)

2117 of 3145 relevant lines covered (67.31%)

13.55 hits per line