microsoft / RulesEngine / 26522805549

95%

master: 97%

push

github

Fix #624, #704, #711, #714, #717: action exception propagation, list schema merging, OutputExpression error hint, global-param dedup, object-return diagnostics (#728)

* Fix #717, #711, #714, #704, #624: bug bash batch

#624: ActionBase.ExecuteAndReturnResultAsync silently captured every
exception into result.Exception regardless of EnableExceptionAsErrorMessage,
so an action throwing inside Run() never propagated when the setting was
false. Add ThrowIfActionExceptionShouldPropagate in RulesEngine to honor
the contract documented on ReSettings.

#711: OutputExpressionAction emitted a cryptic
"Expression is missing an 'as' clause" when users wrote C#-style anonymous
objects (`new { X = ... } as Result`). Detect the pattern and wrap the
parse exception with a clear hint pointing at the Dynamic.Core syntax
(`new (value as Name, ...)`).

#714: Global params were re-evaluated for every rule in the workflow,
so `Utils.FromDb(myInput)` ran N times per ExecuteAllRulesAsync call.
Move the global-params compilation+evaluation to workflow scope: compile
a single delegate at RegisterRule time, store it in RulesCache, evaluate
once in ExecuteAllRuleByWorkflow and append the result as RuleParameters
to each compiled rule. Preserve the existing per-rule error messages when
global compilation or evaluation fails. ExecuteActionWorkflowAsync
(which bypasses RulesCache) evaluates globals ad-hoc.

#704: Utils.CreateAbstractClassType used only list[0] when generating the
CLR type for a heterogeneous IList of ExpandoObject/Dictionary, so any
property appearing only in later elements was dropped. Walk every element
and union the schema; recursively merge nested dictionaries.

#717: Methods declared to return `object` cannot have their result
members accessed in Dynamic.Core expressions — the parser errors with
"exists in type 'Object'" or "is not defined for the types 'System.Object'".
We can't unbox at parse time, but the error message gave no clue what was
wrong. Detect t... (continued)

446 of 558 branches covered (79.93%)

106 of 112 new or added lines in 6 files covered. (94.64%)

820 of 857 relevant lines covered (95.68%)

524.37 hits per line