Qiskit / qiskit / 26520813064

88%

Build Type

push

github

Committed by web-flow

Commit Message

Use public `qiskit.circuit` APIs in `qiskit.synthesis` (#16253)

* Use public `qiskit.circuit` APIs in `qiskit.synthesis`

We have a long-standing problem of `qiskit.circuit` reversing the module
hierarchy and including import-time imports of `qiskit.synthesis`.  The
synthesis module is supposed to be higher level than `circuit`, and only
used to provide the "default" (`Instruction.definition`) syntheses of
various library objects.  Those imports should be done at runtime of the
`_define` methods.

This ensures that `qiskit.synthesis` is only using `qiskit.circuit` via
its public interface, which is how the module API-boundary separation is
supposed to work.  This is a little more code churn than is ideal, but
my hope is that this is a good stepping stone along the way to properly
fixing the import structure of Qiskit, and that now `synthesis`'s
imports look right everywhere, any new files will copy the correct
style.

I've done the same for `qiskit.quantum_info` where possible, but there's
a couple of places that are using items that _aren't_ publicly exported
(`operators.predicates` is a big one, and might be an oversight in the
`qiskit.quantum_info` module).

* Remove unused import

Coverage Stats

96 of 98 new or added lines in 35 files covered. (97.96%)

11 existing lines in 4 files now uncovered.

108599 of 123957 relevant lines covered (87.61%)

961990.24 hits per line