ponder-lab / Hybridize-Functions-Refactoring / #1700

72%

Build Type

push

travis-pro

Committed by web-flow

Commit Message

Type-discriminate `DynamicDim`/`RaggedDim` in `Function.inferSpec` (#562)

* Type-discriminate `DynamicDim` and `RaggedDim` in `Function.inferSpec`

The per-position consensus loop in `inferSpec` collapsed every non-`NumericDim`
to a `SymbolicDim("?")` wildcard via a fall-through `else`. With Ariadne 0.45.0
shipping typed dim sentinels (`DynamicDim` per wala/ML#545; `RaggedDim` per
ponder-lab/ML#320), the consumer can name those cases explicitly.

Splits the fan-out into independent branches:

- Disagreement across contexts → wildcard.
- `instanceof NumericDim` → keep the concrete value.
- `instanceof DynamicDim` → wildcard (`tf.keras.Input`-style batch axes encode
  as `SymbolicDim("?")` in `TensorSpec`; same surface behavior as before).
- `instanceof RaggedDim` → wildcard, carrying a `TODO(#524)` marker so the
  `RaggedTensorSpec` emission work lands on a clearly-anchored branch.
- Otherwise → wildcard.

Surface behavior is unchanged; the existing `testHasLikelyTensorParameter*`
suite (492 tests, all green) covers the regression surface. Drops the stale
`wala/ML#544` reference from the inline comment—the typed-sentinel half of
that TODO shipped in Ariadne 0.45.0.

Closes #561.

* Use full GitHub URLs for issue refs in `Function.inferSpec` comments

Matches the established source-code convention (see existing TODOs in
`HybridizeFunctionRefactoringProcessor.java`, `Function.java`, etc.). The
GitHub-markdown shortforms (`#N`, `owner/repo#N`) only auto-link in
issue/PR/review bodies, not in Java comments rendered by IDEs and Javadoc.

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

1193 of 1651 relevant lines covered (72.26%)

0.72 hits per line