safe-global / safe-client-gateway / 26511058022

90%

Build Type

push

github

Committed by web-flow

Commit Message

feat(auth): introduce EmailAddress schema (#3096)

* feat(auth): introduce branded EmailAddress schema

Adds a shared EmailAddressSchema and EmailAddress branded type under
validation/entities/schemas/. Replaces 5 inline z.email().max(255)
declarations and the hand-rolled .trim().toLowerCase() normalization
inside UsersRepository.

- EmailAddressSchema normalizes (trim + lowercase) and validates via
  z.email().max(255), then brands the output. Matches UuidSchema pattern.
- User (domain), DB User, Auth0Token, UserSession, and the three email
  env vars in configuration.schema now use the shared schema.
- UsersRepository.persistVerifiedEmail and assertEmailNotTaken drop the
  inline .trim().toLowerCase(); the schema produces an already-normalized
  EmailAddress at the boundary.

No HTTP-visible behavior change. Pre-work for WA-2327 (email invites).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(auth): migrate fake email construction to fakeEmailAddress helper

Test fixtures previously produced string-typed emails via
faker.internet.email() (sometimes with manual .toLowerCase()).
With EmailAddress now branded, every fixture must yield an
EmailAddress instance.

Adds fakeEmailAddress() under validation/entities/schemas/__tests__/
that wraps EmailAddressSchema.parse(faker.internet.email()). Spec
files across auth, users, and spaces modules migrate to it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor(auth): derive EmailAddress type from the schema

Drop the manual `string & { __brand: 'EmailAddress' }` and the
explicit transform, and let the zod schema's `.toLowerCase()`
output drive the inferred type via `z.infer`. Same downstream
shape (lowercased, valid email, max 255 chars), one source of truth.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(auth): actually brand EmailAddress; revert config-var changes

Address review feedback on PR #3096:

- Add `.brand<'... (continued)

Coverage Stats

4297 of 5157 branches covered (83.32%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 6 files covered. (100.0%)

1 existing line in 1 file now uncovered.

16205 of 17696 relevant lines covered (91.57%)

618.21 hits per line