prisma-risk / tsoracle / 26494548553

95%

push

github

refactor(consensus)!: typed AdvanceOutOfRange variant end-to-end (#569)

Promote the rejected-out-of-range advance from a `Box<dyn Error>`-erased
`PermanentDriver` source to a first-class `ConsensusError::AdvanceOutOfRange(u64)`
variant. The offending value is now carried structurally from the propose-time
guard, through the server's disposition layer, into both consumers — no
downcasting, no re-boxing in `classify`.

The breaking change is the removal of the public `AdvanceOutOfRange` struct
and its `pub use` re-export from `tsoracle-consensus`. The only downcaster in
the tree was the crate's own test; no external consumer is affected.

`PersistDisposition::OutOfRange(u64)` carries the value end-to-end at the
server layer rather than collapsing into `Permanent(Box::new(...))`. This
follows the disposition module's stated design philosophy — "a new
ConsensusError variant becomes one edit here plus a compiler-forced arm at
each site" — and lets the fence path reconstruct
`ConsensusError::AdvanceOutOfRange(n)` faithfully instead of laundering it
back into `PermanentDriver`. `service.rs` reuses the variant's `Display` so
the message text stays pinned to a single source of truth in `ConsensusError`.

Three driver tests that previously asserted `matches!(_, PermanentDriver(_))`
on the OOR path are strengthened to assert the new variant carries the
expected `u64`; the unrelated `PermanentDriver(_)` assertions (storage I/O,
Raft fatal, paxos pending-reconfig, watch-task death) are unchanged.

Verified `cargo test --workspace --all-features` (1158 passed, 0 failed),
`cargo clippy --workspace --all-features --all-targets -- -D warnings`
(clean), and the license-header script.

Signed-off-by: Sebastian Thiebaud <sebastian@prismarisk.com>

23 of 36 new or added lines in 8 files covered. (63.89%)

14195 of 14966 relevant lines covered (94.85%)

360665.96 hits per line