prisma-risk / tsoracle / 26491638902

95%

push

github

refactor(core)!: clearer leadership naming + Applied { high_water } (#566)

Rename Allocator::try_on_leadership_gained -> become_leader and
Allocator::on_leadership_lost -> step_down. The asymmetric try_ prefix
on the gain path was redundant against the Result return type; reserve
try_ for the "fallible peer of an infallible sibling" pattern
(e.g., try_grant vs would_grant).

Convert CommitOutcome::Applied(u64) to Applied { high_water: u64 } so
every construction site reads as a self-describing literal and so future
extensions can add fields additively instead of breaking tuple arity.

ServingCore::seed_on_leadership_gained is intentionally kept: its
"seed in-memory state from the durably-fenced floor/ceiling" semantic
is distinct from the inner state-machine transition and renaming would
erase that layer boundary. ServingCore::step_down already used that
name at the wrapper layer; the inner rename simply makes the two read
the same way.

Signed-off-by: Sebastian Thiebaud <sebastian@prismarisk.com>

40 of 40 new or added lines in 2 files covered. (100.0%)

13764 of 14498 relevant lines covered (94.94%)

386478.47 hits per line