wboayue / rust-ibapi / 26482901158

92%

push

github

proto-only: WSH decoders + fixtures (PR-D4a) (#642)

* proto-only: WSH decoders + fixtures (PR-D4a)

Flip WshMetaData (104) and WshEventData (105) to proto-only via
require_proto() + decode_wsh_*_proto, mirroring the C-series scanner /
contracts / orders migrations. Per C# Constants.cs PROTOBUF_MSG_IDS, both
have been proto since MIN_SERVER_VER_PROTOBUF_NEWS_DATA (209) — well
below our floor of 213.

Production:
- decode_wsh_metadata / decode_wsh_event_data become 1-line proto
  delegators; #[allow(dead_code)] dropped from the *_proto helpers.
- decode_metadata_message / decode_event_data_message wrappers handle
  message-type dispatch (WshMetaData / Error / catch-all) consistently
  for both metadata and event_data; sync + async one_shot_request_with_retry
  closures use the wrappers.
- stream_decoders.rs Error arm passes &*message via the new
  From<&ResponseMessage> for Error impl (added in errors.rs) instead of
  cloning.

Tests:
- WshMetadataResponse / WshEventDataResponse proto builders added in
  src/testdata/builders/wsh.rs with ResponseProtoEncoder impls.
- WSH_METADATA_DECODE_TESTS / WSH_EVENT_DATA_DECODE_TESTS reshaped from
  &'static str message → { req_id, data_json } with metadata_message() /
  event_data_message() helpers that build proto-framed ResponseMessages.
- All response_messages: Vec<String> fixtures across test_tables.rs and
  wsh/{sync,async}_tests.rs migrated to ordered_responses:
  Vec<ResponseMessage> via proto_response + builders.
- build_response / build_error_response helpers in test_data.rs deleted
  (no remaining callers).
- Inline text-decode tests in common_tests.rs removed — proto-side
  coverage lives in decoders.rs unit tests.
- Two _rejects_text_framing regression tests added in
  wsh/common/decoders.rs per CLAUDE.md rule 19.

Plan:
- plans/floor-213-ratchet.md D4 section updated: D4a (WSH) marked open,
  D4b (TickEFP) keeps default to stay text-only.

* /simplify: collapse duplicate WSH dispatch + tighten docs/t... (continued)

112 of 116 new or added lines in 7 files covered. (96.55%)

19254 of 20867 relevant lines covered (92.27%)

27.8 hits per line