wboayue / rust-ibapi / 26481690486

92%

push

github

proto-only: drop dual-format discriminator on ResponseMessage (PR-D3) (#641)

* proto-only: drop dual-format discriminator on ResponseMessage (PR-D3)

D3 conservative subset: collapse the four pieces of the dual-format
discriminator that are actually unblocked, leaving the residual text path
(parse_raw_message text branch + ResponseMessage::from(s) + field iteration)
for D4 paired with WSH + TickEFP migration.

Deleted from src/messages.rs:
- is_protobuf field — production no longer reads it after D2; framing is
  now discriminated by raw_bytes.is_some() alone.
- server_version field — already #[allow(dead_code)] at the end of D2.
- with_server_version test helper.
- from_binary_text helper — only production caller (parse_raw_message text
  branch) gets the field-building logic inlined.

parse_raw_message drops the unused server_version: i32 parameter.

Test fixtures across errors_tests, messages/tests, transport/routing_tests,
transport/sync/tests, connection/common_tests, market_data/realtime decoders,
and the common::test_utils::proto_response helper drop their trailing
server_version arg on from_protobuf calls. Three Error::unexpected_response
struct-literal sites in client/error_handler/tests collapse to
ResponseMessage::from("45\0"). Scanner _rejects_text_framing tests drop the
now-meaningless .with_server_version(...) decoration.

* plans: link PR #641 in floor-213 D3 status

* /simplify: fold from_protobuf callsites to proto_response helper

Picked up the existing proto_response(IncomingMessages, Vec<u8>) helper at
the 26 from_protobuf callsites this PR already touched. Drops the
"X as i32" cast and bare ResponseMessage:: prefix at every site:

- transport/routing_tests.rs: 11 sites, add import
- transport/sync/tests.rs: 5 sites, extend existing helpers import
- connection/common_tests.rs: 8 sites + the proto_frame helper at 761;
  promote the existing inner-mod import to file scope, drop 3 dupes
- market_data/realtime/common/decoders/tests.rs... (continued)

13 of 13 new or added lines in 5 files covered. (100.0%)

19188 of 20802 relevant lines covered (92.24%)

27.0 hits per line