wboayue / rust-ibapi / 26479979442

92%

push

github

proto-only: collapse ResponseMessage accessors + drop dead helpers (PR-D2) (#640)

* proto-only: collapse ResponseMessage accessors + drop dead helpers (PR-D2)

order_id() and execution_id() are proto-only at floor 213 — every callable
message type (OpenOrder, OrderStatus, ExecutionData{,End}, CommissionsReport)
arrives proto-framed. Drop the proto_or_text_int / proto_or_text_string
helpers; inline the proto/text fork into request_id() (kept dual-format —
TickEFP is the lone text-only inbound). Delete order_id_index, peek_string,
next_long, next_optional_int/long/double, next_bool, next_date_time*,
parse_ib_date_time_with_timezone / resolve_primitive_date_time, and the
UNSET_*/INFINITY_STR constants + time_tz imports they fed.

Migrate 7 transport routing tests (sync + async) from text-framed body() to
new body_proto<T: prost::Message>() — text-framed OpenOrder/OrderStatus/
ExecutionData/CommissionsReport no longer route since the proto-only
accessors return None for them, which was hanging subscriptions.
The test_bus_send_order_request Exchange responses switch to
ResponseMessage::from_protobuf for the order family.
test_order_message_routing collapses to
test_order_message_routing_without_order_id_returns_sentinel — the proto
positive cases are already covered by sibling per-type tests.

is_protobuf field annotated #[allow(dead_code)] (production reads gone,
test fixtures still write/read it); D3 deletes the field.

* plans: record PR #640 (D2) opened in floor-213 tracker

* /simplify: reuse helpers::binary_proto + strip PR-history language

- Replace the per-file `body_proto` test helper in both transport test
  files with the existing `helpers::binary_proto` (callers convert
  `IncomingMessages` → i32 inline, matching the established convention).
- Strip "post-floor-213" / "PR-D2" / "D3 removes it" / "historical
  text-path" language from doc-comments on `request_id_index`,
  `is_protobuf`, `request_id`, `order_id`, `execution_id`, `peek_int`,
  a... (continued)

10 of 10 new or added lines in 1 file covered. (100.0%)

19199 of 20813 relevant lines covered (92.25%)

27.34 hits per line