26473236552
85%
master: 85%

Ran 26 May 2026 08:30PM UTC

Jobs 1

Files 52

Run time 1min

Badge

Embed ▾

Committed 26 May 2026 08:27PM UTC coverage: 84.582%. First build

Build # 26473236552

Build Type

Pull #2077

github

Committed by

paskal

Commit Message

fix: webhook template flag default override masking safe fallback

Copilot flagged the audit's "real default" claim and was right. server.go:286
had default:"{\"text\": \"{{.Text}}\"}" — the literal, JSON-unsafe template
that produces invalid JSON if a comment contains a quote or newline. The
notify package (webhook.go:50) has a safer fallback:

    if params.Template == "" {
        params.Template = webhookDefaultTemplate
    }

where webhookDefaultTemplate is {"text": {{.Text | escapeJSONString}}}. But
go-flags applies its default tag at parse time, so the field is never empty
when the user omits --notify.webhook.template, and the safer fallback never
runs.

Drop the unsafe default tag so the webhook package's escapeJSONString-based
default takes effect. Also:
- fix the --help description (was "webhook authentication template", but
  it's a payload template, not an auth one; same for headers).
- update parameters/index.md to document the actual safe default
  ({{.Text | escapeJSONString}}); escape the cell's | as \| so kramdown
  doesn't treat it as a column separator.
- typo: "bellow" -> "below" in the headers env-delim comment.

Pull Request Pull Request #2077: fix: parameter docs + --help text inconsistencies (audit)

Coverage Stats

6347 of 7504 relevant lines covered (84.58%)

34.75 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	26473236552.1	26 May 2026 08:30PM UTC	52	84.58	GitHub Action Run

umputun / remark42 / 26473236552
85%
master: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 26473236552

umputun / remark42 / 26473236552 85% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 26473236552

umputun / remark42 / 26473236552
85%
master: 85%

README BADGES
x