DeRuina / timberjack / 26472915163

89%

Build Type

push

github

Committed by DeRuina

Commit Message

fix: correct five bugs in write path, scheduled rotation, and sanitization

  - Write-after-close: use configured FileMode (not hardcoded 0o644) and
    l.resolvedOpenFile instead of os.OpenFile directly
  - Write-after-close: enforce MaxSize limit, matching normal write path
  - runScheduledRotations: set lastRotationTime to nextRotationAbsoluteTime
    (the logical mark) instead of nowFn(), preventing duplicate rotations
  - sanitizeReason: treat '_' like '-' in the duplicate-separator guard so
    underscore-then-space no longer produces "_-" in backup filenames
  - openExistingOrNew: use osOpenFile global instead of os.OpenFile directly
    for the O_APPEND open, making the path interceptable by tests

  Tests added for all five cases.

Coverage Stats

12 of 12 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

768 of 858 relevant lines covered (89.51%)

44.09 hits per line