wboayue / rust-ibapi / 26471815851

92%

push

github

proto-only: collapse caller is_protobuf branches (PR-D1) (#639)

* proto-only: collapse caller is_protobuf branches (PR-D1)

After PR-C series, every Error / NextValidId / dual-format branch is
unreachable post-floor-213. Collapse the callers:

- Notice::from(&ResponseMessage): proto-only via decode_error_envelope,
  DecodedError::default() fallback if raw_bytes is absent.
- determine_routing Error arm: drop is_protobuf fork; delete
  extract_text_error helper.
- decode_next_valid_id: last decode_proto_or_text caller, now proto-only
  with &ResponseMessage receiver; sync/async callers drop &mut.
- parse_raw_message: delete legacy server_version < PROTOBUF branch;
  transport routing tests' body() now emits [4-byte BE msg_id][NUL
  fields]; stubbed connection's server_version cache set to 213.
  Error fixtures route through new body_error() / proto_error_response
  helpers that emit proto::ErrorMessage envelopes.

Sweep dead in messages.rs: peek_long, error_* accessors, ResponseMessage::
decode_proto_or_text. with_server_version gated #[cfg(test)]; server_version
field #[allow(dead_code)] (D3 removes it).

Plan tracker updated; D2/D3 still pending.

* /simplify PR-D1: consolidate proto-Error helpers and set_server_version

Three review agents flagged the same duplication: 9 sites built the
identical proto::ErrorMessage envelope inline.

- Add error_envelope(rid, code, msg) -> proto::ErrorMessage and
  error_frame(rid, code, msg) -> Vec<u8> in test_utils::helpers next to
  proto_error_response (which now delegates to error_envelope).
- Delete duplicated body_error / error_frame helpers (transport
  sync+async, connection sync+async). Callers use the shared helper.
- Inline ErrorMessage builds in client/sync_tests, client/async_tests,
  messages/tests now go through error_frame / proto_error_response.
- Add Connection::set_server_version_for_test (sync + async) so
  make_bus() no longer reaches into pub(crate) internals on different
  shapes per stack.
-... (continued)

48 of 48 new or added lines in 13 files covered. (100.0%)

19341 of 20961 relevant lines covered (92.27%)

27.47 hits per line