mroderick / codebar-planner / 26470721262

95%

master: 95%

push

github

fix: deliver monthly attendance reminder emails

send_monthly_attendance_reminder_emails has been broken since the feature
was introduced in 2016. It instantiates a mailer message but never calls
deliver_now or deliver_later, so the message is discarded without ever
being sent.

Since the method is already wrapped in handle_asynchronously, the correct
fix is deliver_now (send synchronously within the already-async job).

Also converts the existing :wip test from a mock-based assertion to a
delivery assertion, verifying that emails are actually sent.

Fixes discussion #2593

1 of 1 new or added line in 1 file covered. (100.0%)

3556 of 3730 relevant lines covered (95.34%)

41.94 hits per line