|
Ran
|
Jobs
1
|
Files
923
|
Run time
3min
|
Badge
README BADGES
|
push
github
Initialize ConstrainedReschedule.target unconditionally (#16246) (#16280) * Initialize ConstrainedReschedule.target unconditionally `ConstrainedReschedule.__init__` only assigned `self.target` inside the `if target is not None` branch. When the pass was constructed without a `target=` argument (the alignment-only path that the docstring still advertises), `run()` raised AttributeError: 'ConstrainedReschedule' object has no attribute 'target' at the call to the Rust `constrained_reschedule` helper. The Rust function's `target` parameter is `Option<&Target>`, so passing `None` is supported; `self.target` simply needed to be initialised. Adds a regression test that exercises the alignment-only path. Fixes #16245 * Address review feedback: trim reno, strengthen test, add attribution - Reno: adopt @jakelishman's shorter suggested wording. - Test: trim the long docstring (git holds the rest). - Test: replace the implicit "doesn't raise" assertion with a positive assertion that the alignment-only path returns the expected node_start_time for an already-aligned circuit. The shifted-alignment behaviour is tracked separately in #16186 / #16210, so this PR's test exercises the no-shift case. - Test: add the Claude Opus 4.7 attribution comment per the LLM policy discussion. --------- (cherry picked from commit 6412c2f37) Co-authored-by: Greg Neighbors <gkneighb@mac.com> Co-authored-by: gkneighb <gkneighb@users.noreply.github.com>
104322 of 118862 relevant lines covered (87.77%)
1009718.8 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 6 |
97.63
|
0.0% | crates/qasm2/src/parse.rs |
| 3 |
92.03
|
0.0% | crates/qasm2/src/lex.rs |
| 2 |
74.42
|
0.29% | crates/circuit/src/parameter/symbol_expr.rs |
| 1 |
90.53
|
0.0% | crates/circuit/src/parameter/parameter_expression.rs |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 26466355889.1 | 923 |
87.77
|
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|