ponder-lab / Hybridize-Functions-Refactoring / #1659
72%
main: 76%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-586-e377fcbfd25637036a706d493a4c924f865087ae
DEFAULT BRANCH: main
Ran
Jobs 1
Files 31
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.219%. Remained the same
#1659

Pull #551

travis-pro

khatchad 
Split `testHasLikelyTensorParameterHelper` and replace `isPresent`+`get`

Two separate concerns about `Optional` usage in the general helper
introduced in #547, both tracked in #548.

(1) The body asserted the inferred signature using the `isPresent`+`get`
pattern that `Optional` was designed to replace. Replace with
`Optional::map` plus a direct equality comparison; presence and value are
checked in a single assertion via `Optional`'s value-based equality.

(2) The helper took `Optional<List<TensorType>>` as a parameter type,
which Brian Goetz has cautioned against ("Optional was intended for
return types, not parameter or field types"). The single helper
overloaded on three states (structural-only / audit-with-signature /
audit-with-drop) using two null sentinels and an `Optional.empty()`
sentinel, blurring caller intent.

Split into three named methods with no overloaded sentinels:

- `testHasLikelyTensorParameterHelper(boolean, boolean, Set, Set, List)`
  asserts an expected non-empty input signature. `expectedSignature` is
  required to be non-`null`; for the drop case, callers must use
  `ExpectingDrop` instead.
- `testHasLikelyTensorParameterHelperExpectingDrop(boolean, boolean, Set, Set)`
  asserts the inferred input signature is dropped. Same structural and
  per-parameter assertions as the audit method; only the final signature
  comparison differs.
- `testHasLikelyTensorParameterHelper(boolean, boolean)` (unchanged
  signature) remains structural-only. Inlines its body—no longer
  delegates through a five-parameter helper with null sentinels.

Update all convenience overloads (`(TensorType, TensorType)`,
`(TensorType)`, `(boolean, TensorType)`, `MultiContext`) to call the
audit-with-signature method with a plain `List`. Update `HelperNoTensor`
to call `ExpectingDrop`. Update fixture 11's direct call site to drop
the `Optional.of(...)` wrapper.

Closes #548

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Pull Request #551: Split helper into named methods and drop `Optional` parameter

1188 of 1645 relevant lines covered (72.22%)

0.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 #1659.1 31
72.22
Source Files on build #1659